linux-kernel - [PATCH 1/3] modules: fix modparam async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1454631253-14379-2-git-send-email-rusty@rustcorp.com.au>
Date:	Fri,  5 Feb 2016 10:44:11 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	linux-kernel@...r.kernel.org
Cc:	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Weilong Chen <chenweilong@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"PDate:Wed"@ozlabs.org, 3@...abs.org, Feb@...abs.org,
	2016@...abs.org, "16:55:26"@ozlabs.org, +1030@...abs.org,
	Hannes Reinecke <hare@...e.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	stable@...r.kernel.org (4.2+),
	Rusty Russell <rusty@...tcorp.com.au>
Subject: [PATCH 1/3] modules: fix modparam async_probe request

From: "Luis R. Rodriguez" <mcgrof@...e.com>

Commit f2411da746985 ("driver-core: add driver module
asynchronous probe support") added async probe support,
in two forms:

  * in-kernel driver specification annotation
  * generic async_probe module parameter (modprobe foo async_probe)

To support the generic kernel parameter parse_args() was
extended via commit ecc8617053e0 ("module: add extra
argument for parse_params() callback") however commit
failed to f2411da746985 failed to add the required argument.

This causes a crash then whenever async_probe generic
module parameter is used. This was overlooked when the
form in which in-kernel async probe support was reworked
a bit... Fix this as originally intended.

Cc: Hannes Reinecke <hare@...e.de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: stable@...r.kernel.org (4.2+)
Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au> [minimized]
Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
---
 kernel/module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 8358f4697c0c..2149f7003e49 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3496,7 +3496,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
 
 	/* Module is ready to execute: parsing args may do that. */
 	after_dashes = parse_args(mod->name, mod->args, mod->kp, mod->num_kp,
-				  -32768, 32767, NULL,
+				  -32768, 32767, mod,
 				  unknown_module_param_cb);
 	if (IS_ERR(after_dashes)) {
 		err = PTR_ERR(after_dashes);
-- 
2.5.0