linux-kernel - Re: [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160205074804.GF12345@mail.corp.redhat.com>
Date:	Fri, 5 Feb 2016 08:48:04 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	jikos@...nel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid:Add warning message if sysfs group is not created
 for passed kobject in the function, mt_probe

Hi Nick,

On Feb 04 2016 or thereabouts, Nicholas Krause wrote:
> This adds a warning message stating that the sysfs group was not
> able to be created for the passed hid_device structure pointer
> with dev_warn.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/hid/hid-multitouch.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 296d499..b2b2451 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1133,6 +1133,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  		return ret;
>  
>  	ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group);
> +	if (ret)
> +		dev_warn(&hdev->dev, "Cannot allocate sysfs group for %s\n", hdev->name);

Just nitpicking here. Checkpatch.pl complains about a line over 80
characters here. Could you (or maybe just Jiri) fix that?

Otherwise:
Reviewed-by: Benjamin Tissoires <benajmin.tissoires@...hat.com>

Cheers,
Benjamin

>  
>  	mt_set_maxcontacts(hdev);
>  	mt_set_input_mode(hdev);
> -- 
> 2.5.0
>