linux-kernel - Re: [PATCH 3/5] sound: query dynamic DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hwpqj1p98.wl-tiwai@suse.de>
Date:	Fri, 05 Feb 2016 10:26:59 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Joonsoo Kim" <js1304@...il.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Christian Borntraeger" <borntraeger@...ibm.com>,
	"Chris Metcalf" <cmetcalf@...hip.com>,
	"David Rientjes" <rientjes@...gle.com>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	<linux-mm@...ck.org>, "Joonsoo Kim" <iamjoonsoo.kim@....com>,
	"Christoph Lameter" <cl@...ux.com>, <linux-api@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] sound: query dynamic DEBUG_PAGEALLOC setting

On Thu, 04 Feb 2016 06:56:24 +0100,
Joonsoo Kim wrote:
> 
> We can disable debug_pagealloc processing even if the code is complied
> with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query
> whether it is enabled or not in runtime.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>

Acked-by: Takashi Iwai <tiwai@...e.de>


Takashi


> ---
>  sound/drivers/pcsp/pcsp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c
> index 27e25bb..72e2d00 100644
> --- a/sound/drivers/pcsp/pcsp.c
> +++ b/sound/drivers/pcsp/pcsp.c
> @@ -14,6 +14,7 @@
>  #include <linux/input.h>
>  #include <linux/delay.h>
>  #include <linux/bitops.h>
> +#include <linux/mm.h>
>  #include "pcsp_input.h"
>  #include "pcsp.h"
>  
> @@ -148,11 +149,11 @@ static int alsa_card_pcsp_init(struct device *dev)
>  		return err;
>  	}
>  
> -#ifdef CONFIG_DEBUG_PAGEALLOC
>  	/* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets alert */
> -	printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> -	       "which may make the sound noisy.\n");
> -#endif
> +	if (debug_pagealloc_enabled()) {
> +		printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> +		       "which may make the sound noisy.\n");
> +	}
>  
>  	return 0;
>  }
> -- 
> 1.9.1
> 
>