linux-kernel - Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56B47249.1060603@suse.cz>
Date:	Fri, 5 Feb 2016 10:58:33 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux@...ck-us.net, arnd@...db.de, rusty@...tcorp.com.au
Subject: Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure

On 2016-02-04 18:09, Ard Biesheuvel wrote:
> -	${NM} -n ${1} | \
> -		scripts/kallsyms ${kallsymopt} | \
> -		${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -
> +	# capture the return code of scripts/kallsyms in $RC
> +	local RC=`(${NM} -n ${1} | \
> +		(scripts/kallsyms ${kallsymopt}; echo $? 1>&3) | \
> +		${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -) 3>&1`
> +
> +	[ $RC -eq 0 ]

This now ignores errors by the assembler (and makes the function hard to
read). Please change it to use a temporary file.

Michal