linux-kernel - Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu_WAsRUjxbG5wCjSBBYqAHLWBpM8G7pj04snoEsgeOcUg@mail.gmail.com>
Date:	Fri, 5 Feb 2016 13:05:53 +0100
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Laura Abbott <labbott@...oraproject.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Mark Rutland <mark.rutland@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting

On 4 February 2016 at 20:43, Laura Abbott <labbott@...oraproject.org> wrote:
>
> With CONFIG_DEBUG_PAGEALLOC, pages do not have the valid bit
> set when free in the buddy allocator. Add an indiciation to
> the page table dumping code that the valid bit is not set,
> 'F' for fault, to make this easier to understand.
>
> Signed-off-by: Laura Abbott <labbott@...oraproject.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 5a22a11..f381ac9 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -90,6 +90,11 @@ struct prot_bits {
>
>  static const struct prot_bits pte_bits[] = {
>         {
> +               .mask   = PTE_VALID,
> +               .val    = PTE_VALID,
> +               .set    = " ",
> +               .clear  = "F",
> +       }, {
>                 .mask   = PTE_USER,
>                 .val    = PTE_USER,
>                 .set    = "USR",
> --
> 2.5.0
>