linux-kernel - Re: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 10:42:30 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Marcin Ślusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v2] perf tools: handle spaces in file names obtained from
 /proc/pid/maps

Em Thu, Feb 04, 2016 at 11:39:25PM +0100, Marcin Ślusarz escreveu:
> On Tue, Jan 19, 2016 at 08:03:03PM +0100, Marcin Ślusarz wrote:
> > Steam frequently puts game binaries in folders with spaces.
> > 
> > Note: "(deleted)" markers are now treated as part of the file name.
> > 
> > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> > ("perf tools: Use sscanf for parsing /proc/pid/maps").
> > 
> > Signed-off-by: Marcin Ślusarz <marcin.slusarz@...il.com>
> > Acked-by: Namhyung Kim <namhyung@...nel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Gentle ping ;)

Thanks for being gentle, appreciated ;-)

Applied to perf/core,

- Arnaldo
 
> > ---
> >  tools/perf/util/event.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> > index 8b10621..956187b 100644
> > --- a/tools/perf/util/event.c
> > +++ b/tools/perf/util/event.c
> > @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> >  		strcpy(execname, "");
> >  
> >  		/* 00400000-0040c000 r-xp 00000000 fd:01 41038  /bin/cat */
> > -		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> > +		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
> >  		       &event->mmap2.start, &event->mmap2.len, prot,
> >  		       &event->mmap2.pgoff, &event->mmap2.maj,
> >  		       &event->mmap2.min,
> > -- 
> > 2.1.4
> >