linux-kernel - Re: [PATCH 1/2] xen/scsiback: correct frontend counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B4C2D6.6010107@oracle.com>
Date:	Fri, 5 Feb 2016 10:42:14 -0500
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xen.org, konrad.wilk@...cle.com,
	david.vrabel@...rix.com
Cc:	stable@...r.kernel.org
Subject: Re: [PATCH 1/2] xen/scsiback: correct frontend counting



On 02/05/2016 08:21 AM, Juergen Gross wrote:
> When adding a new frontend to xen-scsiback don't decrement the number
> of active frontends in case of no error. Not doing so results in a

I think you meant "Doing so".

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>


> failure when trying to remove the xen-pvscsi nexus even if no domain
> is using it.
>
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Cc: stable@...r.kernel.org
> ---
>   drivers/xen/xen-scsiback.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
> index ad4eb10..51387d7 100644
> --- a/drivers/xen/xen-scsiback.c
> +++ b/drivers/xen/xen-scsiback.c
> @@ -939,12 +939,12 @@ out:
>   	spin_unlock_irqrestore(&info->v2p_lock, flags);
>   
>   out_free:
> -	mutex_lock(&tpg->tv_tpg_mutex);
> -	tpg->tv_tpg_fe_count--;
> -	mutex_unlock(&tpg->tv_tpg_mutex);
> -
> -	if (err)
> +	if (err) {
> +		mutex_lock(&tpg->tv_tpg_mutex);
> +		tpg->tv_tpg_fe_count--;
> +		mutex_unlock(&tpg->tv_tpg_mutex);
>   		kfree(new);
> +	}
>   
>   	return err;
>   }