linux-kernel - Re: [PATCH v7 04/10] ppc64 ftrace_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160205113032.620c97f3@gandalf.local.home>
Date:	Fri, 5 Feb 2016 11:30:32 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Petr Mladek <pmladek@...e.com>
Cc:	Torsten Duwe <duwe@....de>, Michael Ellerman <mpe@...erman.id.au>,
	Jiri Kosina <jkosina@...e.cz>, Miroslav Benes <mbenes@...e.cz>,
	Jessica Yu <jeyu@...hat.com>, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org
Subject: Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables

On Fri, 5 Feb 2016 17:18:34 +0100
Petr Mladek <pmladek@...e.com> wrote:

> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index a138f6d..de6dab0 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -449,7 +449,7 @@ config PROBE_EVENTS
>  	def_bool n
>  
>  config DYNAMIC_FTRACE
> -	bool "enable/disable function tracing dynamically"
> +	bool "Enable/Disable function tracing dynamically"
>  	depends on FUNCTION_TRACER
>  	depends on HAVE_DYNAMIC_FTRACE
>  	default y
> @@ -472,9 +472,17 @@ config DYNAMIC_FTRACE
>  	  otherwise has native performance as long as no tracing is active.
>  
>  config DYNAMIC_FTRACE_WITH_REGS
> -	def_bool y
> +	bool "Pass registers to function tracer"
>  	depends on DYNAMIC_FTRACE
>  	depends on HAVE_DYNAMIC_FTRACE_WITH_REGS
> +	default y
> +	help
> +	  This option enables passing the current state of processor
> +	  registers to the function tracer. It allows to do a more
> +	  detailed analyze and print more information.
> +
> +	  Say Y here if you are unsure. The only exception is if
> +	  you want to pass a build error caused by a broken compiler.
>  
>  config FUNCTION_PROFILER
>  	bool "Kernel function profiler"
> 
> 
> I made "enable/disable" uppercase because it looked weird in
> context of other descritions.
> 

This works too, and I'm fine with it.

-- Steve