linux-kernel - [RESEND x2][PATCH v2] block: partition: Add partition specific uevent callbacks for partition info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1454695303-3181-1-git-send-email-john.stultz@linaro.org>
Date:	Fri,  5 Feb 2016 10:01:43 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	San Mehat <san@...gle.com>, Jens Axboe <axboe@...nel.dk>,
	Rom Lemarchand <romlem@...gle.com>,
	Android Kernel Team <kernel-team@...roid.com>,
	Jeff Moyer <jmoyer@...hat.com>, harald@...hat.com,
	Kees Cook <keescook@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kay Sievers <kay@...y.org>, Dima Zavin <dima@...roid.com>,
	John Stultz <john.stultz@...aro.org>
Subject: [RESEND x2][PATCH v2] block: partition: Add partition specific uevent callbacks for partition info

From: San Mehat <san@...gle.com>

This patch has been carried in the Android tree for quite some
time and is one of the few patches required to get a mainline
kernel up and running with an exsiting Android userspace. So I
wanted to submit it for review and consideration if it should
be merged.

For partitions, add new uevent parameters 'PARTN' which
specifies the partitions index in the table, and 'PARTNAME',
which specifies PARTNAME specifices the partition name of a
partition device.

Android's userspace uses this for creating device node links from the
partition name and number: ie:
	/dev/block/platform/soc/by-name/system
or
	/dev/block/platform/soc/by-num/p1

One can see its usage here:
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#355
and
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#494

Cc: Jens Axboe <axboe@...nel.dk>
Cc: Rom Lemarchand <romlem@...gle.com>
Cc: Android Kernel Team <kernel-team@...roid.com>
Cc: Jeff Moyer <jmoyer@...hat.com>
Cc: harald@...hat.com
Cc: Kees Cook <keescook@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Kay Sievers <kay@...y.org>
Signed-off-by: Dima Zavin <dima@...roid.com>
[Dropped NPARTS and reworded commit message for context]
Signed-off-by: John Stultz <john.stultz@...aro.org>
---
v2: Dropped NPARTS thanks to Jeff noticing it wasn't used

 block/partition-generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/block/partition-generic.c b/block/partition-generic.c
index 746935a..ae95e96 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -216,10 +216,21 @@ static void part_release(struct device *dev)
 	kfree(p);
 }
 
+static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+	struct hd_struct *part = dev_to_part(dev);
+
+	add_uevent_var(env, "PARTN=%u", part->partno);
+	if (part->info && part->info->volname[0])
+		add_uevent_var(env, "PARTNAME=%s", part->info->volname);
+	return 0;
+}
+
 struct device_type part_type = {
 	.name		= "partition",
 	.groups		= part_attr_groups,
 	.release	= part_release,
+	.uevent		= part_uevent,
 };
 
 static void delete_partition_rcu_cb(struct rcu_head *head)
-- 
1.9.1