linux-kernel - Re: [PATCH 2/6] arm64: dts: qcom: apq8016-sbc: add usb support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B4FDEB.2080202@codeaurora.org>
Date:	Fri, 5 Feb 2016 11:54:19 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Andy Gross <andy.gross@...aro.org>
Cc:	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: apq8016-sbc: add usb support

On 02/05/2016 11:01 AM, Srinivas Kandagatla wrote:
> +
> +		usb2513 {
> +			compatible = "smsc,usb3503";
> +			reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>;
> +			initial-mode = <1>;
> +		};
> +
> +		usb_id: usb-id {
> +			interrupt-parent = <&msmgpio>;
> +			compatible = "linux,extcon-usb-gpio";
> +			id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&usb_id_default>;
> +		};

These are not on the SoC bus. Please move them to root.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project