linux-kernel - Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 19:02:12 -0200
From:	Lucas De Marchi <lucas.de.marchi@...il.com>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	lkml <linux-kernel@...r.kernel.org>, linux-iio@...r.kernel.org,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	mwelling@...e.org, linux@...ck-us.net, eibach@...ys.de
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

Hi Daniel,

On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta <daniel.baluta@...el.com> wrote:
> +
> +static const struct i2c_device_id ads1015_id[] = {
> +       {"ads1015", 0},
> +       {}
> +};

Since this module is not 100% compatible with the hwmon version,
wouldn't it be better to use another id?

Other than that, I tested it on the MinnowBoard Max with a Drone Lure
connected and it works fine.

thanks

Lucas De Marchi