linux-kernel - Re: [PATCH v3] synopsys pcie rc generic platform driver update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160205225204.GB11780@localhost>
Date:	Fri, 5 Feb 2016 16:52:04 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Joao Pinto <Joao.Pinto@...opsys.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, Vineet.Gupta1@...opsys.com,
	CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v3] synopsys pcie rc generic platform driver update

Hi Joao,

On Fri, Feb 05, 2016 at 07:55:43PM +0000, Joao Pinto wrote:
> This patch tries to improve the host/pcie-synopsys branch including a new
> driver name, more accurate documentation and centralized link up validation.
> Other platform drivers were also updated to include the new centralized link
> up validation function.

It's true that I wanted you to incorporate a few tweaks I had made in
my pci/host-synopsys branch, but generating incremental patches on top
of that branch makes this too confusing to follow.

My pci/host-synopsys contains two patches on top of v4.5-rc1.  I would
prefer that you

  - fetch that branch,
  - make whatever edits you need, and
  - generate fresh patches based on v4.5-rc1

Then everybody can see the whole series at once without trying to
integrate these changes with the ones you've previously posted, and I
can start from scratch and apply those fresh patches on top of
v4.5-rc1.

It's good that you include summaries of what's changed between
versions, but if people want to see *exactly* what's changed between
your v3 and v4 postings, it's easy for them to download those series,
apply them on different branches, and git diff the branches.

Bjorn