[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <C3050A4DBA34F345975765E43127F10F62D8CE36@SZXEMA512-MBX.china.huawei.com>
Date: Sat, 6 Feb 2016 02:38:05 +0000
From: Caizhiyong <caizhiyong@...ilicon.com>
To: John Stultz <john.stultz@...aro.org>,
Andrew Morton <akpm@...ux-foundation.org>
CC: lkml <linux-kernel@...r.kernel.org>, San Mehat <san@...gle.com>,
"Jens Axboe" <axboe@...nel.dk>, Rom Lemarchand <romlem@...gle.com>,
"Android Kernel Team" <kernel-team@...roid.com>,
Jeff Moyer <jmoyer@...hat.com>,
Harald Hoyer <harald@...hat.com>,
Kees Cook <keescook@...omium.org>, Kay Sievers <kay@...y.org>,
Dima Zavin <dima@...roid.com>, Greg KH <greg@...ah.com>,
"Wanli (welly)" <welly.wan@...ilicon.com>,
Quyaxin <quyaxin@...ilicon.com>
Subject: RE: [RESEND x2][PATCH v2] block: partition: Add partition specific
uevent callbacks for partition info
> > Interestingly, this feature appears to already be documented in
> > Documentation/block/cmdline-partition.txt. I wonder how that happened.
> > Maybe we used to do this but it got taken away?
This documentation talk about the partition name usages,
my patch support get partition name from android userspace.
the mainline kernel appears does not support the 'PARTNAME' uevent, but this feature is very convenient.
>
> Heh. Looks like the documentation was added not too long ago (by Cai -
> cc'ed). I suspect they had been working w/ the Android tree and
> assumed the functionality was already upstream?
>
> > It seems bad that we don't document uevents in any organized fashion.
> > But the audience is very small and knows how to find kernel source code
> > so I guess it doesn't matter.
> >
> > Anyway, please do check that the conveniently self-adding documentation
> > is accurate and complete.
>
> It does match the behavior this patch provides from Android. It is
> somewhat tangential to the functionality described in the
> documentation, so I'm not sure of its measure of completeness (for
> example, it doesn't talk about PARTN parameter, but again, the
> documentation is covering how to specify partition info via the boot
> cmdline, and isn't really covering the uevents - the uevent was just a
> mentioned side-effect for the partition name portion of the cmdline
> option).
>
> thanks
> -john
Powered by blists - more mailing lists