linux-kernel - Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160207123426.GA6022@electric-eye.fr.zoreil.com>
Date:	Sun, 7 Feb 2016 13:34:26 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

Robert Jarzmik <robert.jarzmik@...e.fr> :
> Francois Romieu <romieu@...zoreil.com> writes:
[...]
> > If you have some spare time, it would be nice to avoid db->irq_wake leak
> > on probe failure or driver removal.
> Sorry but not in this patch.

Of course. Different topic => different patch.

> I suppose the right patch would be to use devm_*() in the probe function for
> ioremaps and request_irqs, which would address this point.

I'd rather avoid devm_* on netdev.

-- 
Ueimor