linux-kernel - Re: [PATCH] media: i2c/adp1653: probe: fix erroneous return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160207180845.GE32612@valkosipuli.retiisi.org.uk>
Date:	Sun, 7 Feb 2016 20:08:46 +0200
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Anton Protopopov <a.s.protopopov@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c/adp1653: probe: fix erroneous return value

Hi Anton,

On Sat, Feb 06, 2016 at 11:27:32PM -0500, Anton Protopopov wrote:
> The adp1653_probe() function may return positive value EINVAL
> which is obviously wrong.
> 
> Signed-off-by: Anton Protopopov <a.s.protopopov@...il.com>
> ---
>  drivers/media/i2c/adp1653.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c
> index 7e9cbf7..fb7ed73 100644
> --- a/drivers/media/i2c/adp1653.c
> +++ b/drivers/media/i2c/adp1653.c
> @@ -497,7 +497,7 @@ static int adp1653_probe(struct i2c_client *client,
>  		if (!client->dev.platform_data) {
>  			dev_err(&client->dev,
>  				"Neither DT not platform data provided\n");
> -			return EINVAL;
> +			return -EINVAL;
>  		}
>  		flash->platform_data = client->dev.platform_data;
>  	}

Thanks!

Applied to my tree.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk