lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Feb 2016 14:18:13 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: Bijosh Thykkoottathil <bijosh.t@...mail.com> Cc: devel@...verdev.osuosl.org, adrianremonda@...il.com, linux-kernel@...r.kernel.org, christian.gromm@...rochip.com, sudipm.mukherjee@...il.com, andrey.shvetsov@....de Subject: Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote: > Fixes following coding style issues reported by the check patch script. > - ERROR: Macros with complex values should be enclosed in parentheses > > Moving static storage class to the beginning of declaration fixes these > errors. Well that's a horrid fix for this, as you aren't doing anything different here. Fix the tool if it is reporting things incorrectly, don't blindly change code for no reason please. checkpatch isn't always correct, as you have found out. thanks, greg k-h
Powered by blists - more mailing lists