linux-kernel - Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 07 Feb 2016 12:16:55 +0100
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	arm@...nel.org, Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Jonathan Corbet <corbet@....net>, Jiri Slaby <jslaby@...e.com>,
	linux-serial@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Hans de Goede <hdegoede@...hat.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org,
	Lior Amsalem <alior@...vell.com>,
	Nadav Haklai <nadavh@...vell.com>,
	Omri Itach <omrii@...vell.com>,
	Wilson Ding <dingwei@...vell.com>
Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

Hi Greg,
 
 On dim., févr. 07 2016, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Wed, Feb 03, 2016 at 07:41:20PM +0100, Gregory CLEMENT wrote:
>> +static struct console mvebu_uart_console = {
>> +	.name	= "ttyS",
>
> You aren't ttyS, that's a reserved name for a different chip, please use
> a new name and major/minor numbers.

Oh sorry, I changed the ttyS to ttyMV in the uart_driver struct but I
forgot the console. I will fix it in next version.

Thanks,

Gregory

>
> thanks,
>
> greg k-h

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com