linux-kernel - Re: [PATCH 5/6] create/adjust generated/expsyms.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1602081729190.17825@knanqh.ubzr>
Date:	Mon, 8 Feb 2016 17:45:01 -0500 (EST)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	Michal Marek <mmarek@...e.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, Al Viro <viro@...IV.linux.org.uk>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 5/6] create/adjust generated/expsyms.h

On Mon, 8 Feb 2016, Sam Ravnborg wrote:

> On Mon, Feb 08, 2016 at 03:28:34PM -0500, Nicolas Pitre wrote:
> > Given the list of exported symbols needed by all modules, we can create
> > a header file containing preprocessor defines for each of those symbols.
> > Also, when some symbols are added and/or removed from the list, we can
> > update the time on the corresponding files used as build dependencies for
> > those symbols. And finally, if any symbol did change state, the
> > corresponding source files must be rebuilt.
> > 
> > The insertion or removal of an EXPORT_SYMBOL() entry within a module may
> > create or remove the need for another exported symbol.  This is why this
> > operation has to be repeated until the list of needed exported symbols
> > becomes stable. Only then the final kernel and modules link take place.
> 
> Could this magic with vmlinux_recursive have been implemented in a more
> obvious way in link-vmlinux.sh?
> One of the purposes with link-vmlinux.sh was to make the final link
> stage more readable and this patch goes in the other direction.

I played with different alternatives and this is really the best I came 
up with.  Those alternatives were much uglier.

The adjust_expsyms.sh script must be run only when all vmlinux 
prerequisites have been built i.e descending in all subdirs is done, but 
before actually linking it. And then if some changes in the list of 
exported symbols was detected then all those prerequisites have to be 
re-evaluated again.  The adjust_expsyms.sh invocation could be done from 
link-vmlinux.sh but there would still be a need for a special Make 
target to revisit all dependencies before resuming with the link.

If you have any suggestions for improving this though please feel free 
to share them.

Nicolas