linux-kernel - Re: [PATCH] clk: meson: Fix meson_clk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ7t2brTxmE-snjXxZG1ZrHNYCEugj6EwORBpVtaMHME_pewQ@mail.gmail.com>
Date:	Mon, 8 Feb 2016 09:54:46 +0100
From:	Carlo Caione <carlo@...one.org>
To:	Carlo Caione <carlo@...one.org>
Cc:	Andreas Färber <afaerber@...e.de>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Matthias Brugger <mbrugger@...e.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

On Mon, Feb 8, 2016 at 9:34 AM, Carlo Caione <carlo@...one.org> wrote:
> On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaerber@...e.de> wrote:
>> As preparation for arm64 based mesongxbb, which pulls in this code once
>> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch.
>> The loop uses a local unsigned int variable, so adopt that type,
>> matching the header.
>>
>> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller")
>> Signed-off-by: Andreas Färber <afaerber@...e.de>
>> ---
>>  drivers/clk/meson/clkc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c
>> index c83ae1367abc..d920d410b51d 100644
>> --- a/drivers/clk/meson/clkc.c
>> +++ b/drivers/clk/meson/clkc.c
>> @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf,
>>  }
>>
>>  void __init meson_clk_register_clks(const struct clk_conf *clk_confs,
>> -                                   size_t nr_confs,
>> +                                   unsigned int nr_confs,
>>                                     void __iomem *clk_base)
>>  {
>>         unsigned int i;
>
> Nit: I'd prefer to fix declaration in drivers/clk/meson/clkc.h with
> size_t since we are going to use it for array indexing.

On a second thought it's ok since we use i to cycle through clocks.

Acked-by: Carlo Caione <carlo@...lessm.com>

Cheers,

-- 
Carlo Caione