linux-kernel - Re: [PATCH 5/5] drivers/pci: make most of the PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2730150.DUniNa63fK@wuerfel>
Date:	Mon, 08 Feb 2016 11:00:27 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	Ley Foon Tan <lftan@...era.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Stanimir Varbanov <svarbanov@...sol.com>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 5/5] drivers/pci: make most of the PCI_DW drivers modular

On Sunday 07 February 2016 19:00:44 Paul Gortmaker wrote:
> We've exported the symbols that we know these specific drivers
> will need as tristate, so now we can make the conversion from
> bool to tristate w/o concern for build regressions.
> 
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Ley Foon Tan <lftan@...era.com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Stanimir Varbanov <svarbanov@...sol.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-arm-msm@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Looks good, but I'm not sure what happens on unload. Did you check?
Until this is tested, maybe it's best to prevent module unloading?

	Arnd