linux-kernel - Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160208104211.GQ4782@piout.net>
Date:	Mon, 8 Feb 2016 11:42:11 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lee.jones@...aro.org, k.kozlowski@...sung.com,
	javier@....samsung.com, broonie@...nel.org,
	gregkh@...uxfoundation.org, a.zummo@...ertech.it,
	cw00.choi@...sung.com, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap,
 irq chip locally

On 08/02/2016 at 15:50:06 +0530, Laxman Dewangan wrote :
> 
> On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> >-	ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> >-					max77686_rtc_alarm_irq, 0,
> >-					"rtc-alarm1", info);
> >-	if (ret < 0)
> >+	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> >+				   "rtc-alarm1", info);
> >+	if (ret < 0) {
> >  		dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
> >  			info->virq, ret);
> >+		goto err_rtc;
> >+	}
> >+
> >+	return 0;
> >  err_rtc:
> 
> Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.
> 
> Please let me know if I can respin this patch only instead of entire series.
> 

Sure, you can.

> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com