lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <56B86F95.12384.11AF6415@pageexec.freemail.hu>
Date:	Mon, 08 Feb 2016 11:36:05 +0100
From:	"PaX Team" <pageexec@...email.hu>
To:	linux-tip-commits@...r.kernel.org, zhangyanfei@...fujitsu.com,
	wency@...fujitsu.com, tglx@...utronix.de,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	mingo@...nel.org, imtangchen@...il.com, spender@...ecurity.net,
	hpa@...or.com, tangchen@...fujitsu.com, y14sg1@...cast.net,
	isimatu.yasuaki@...fujitsu.com, akpm@...ux-foundation.org,
	izumi.taku@...fujitsu.com, laijs@...fujitsu.com
CC:	izumi.taku@...fujitsu.com, torvalds@...ux-foundation.org,
	tglx@...utronix.de, akpm@...ux-foundation.org,
	wency@...fujitsu.com, zhangyanfei@...fujitsu.com,
	isimatu.yasuaki@...fujitsu.com, y14sg1@...cast.net,
	tangchen@...fujitsu.com, hpa@...or.com, laijs@...fujitsu.com,
	imtangchen@...il.com, spender@...ecurity.net, mingo@...nel.org
Subject: Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()

On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:

>   for (i = 0; i < numa_meminfo.nr_blks; i++) {
> -		struct numa_memblk *mb = &numa_meminfo.blk[i];
> +		struct numa_memblk *mb = numa_meminfo.blk + i;
> 
> -		memblock_set_node(mb->start, mb->end - mb->start,
> -				  &memblock.reserved, mb->nid);
> +		memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);

if you're not keeping to the 80-char length (no complaints from me on that), could
you also use some whitespace around the '-' operator for more readability?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ