linux-kernel - [tip:irq/core] irqchip/atmel-aic: Remove duplicate bit operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-8c7baa8c3d57004ed3e850fb7a106acf38810e3c@git.kernel.org>
Date:	Mon, 8 Feb 2016 02:49:41 -0800
From:	tip-bot for Milo Kim <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	ludovic.desroches@...el.com, marc.zyngier@....com,
	nicolas.ferre@...el.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	boris.brezillon@...e-electrons.com, jason@...edaemon.net,
	milo.kim@...com, tglx@...utronix.de
Subject: [tip:irq/core] irqchip/atmel-aic: Remove duplicate bit operation

Commit-ID:  8c7baa8c3d57004ed3e850fb7a106acf38810e3c
Gitweb:     http://git.kernel.org/tip/8c7baa8c3d57004ed3e850fb7a106acf38810e3c
Author:     Milo Kim <milo.kim@...com>
AuthorDate: Wed, 13 Jan 2016 16:19:52 +0900
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 8 Feb 2016 11:45:21 +0100

irqchip/atmel-aic: Remove duplicate bit operation

AIC5 priority value is updated twice -
in aic_common_set_priority() and when updating AT91_AIC5_SMR.
Variable, 'smr' has updated priority value (intspec[2]) in the first step,
so no need to update it again in the second step.

Signed-off-by: Milo Kim <milo.kim@...com>
Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: Ludovic Desroches <ludovic.desroches@...el.com>
Cc: Nicholas Ferre <nicolas.ferre@...el.com>
Link: http://lkml.kernel.org/r/1452669592-3401-4-git-send-email-milo.kim@ti.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/irqchip/irq-atmel-aic5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c
index f36f426..4f0d068 100644
--- a/drivers/irqchip/irq-atmel-aic5.c
+++ b/drivers/irqchip/irq-atmel-aic5.c
@@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d,
 	irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR);
 	smr = irq_reg_readl(bgc, AT91_AIC5_SMR);
 	aic_common_set_priority(intspec[2], &smr);
-	irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR);
+	irq_reg_writel(bgc, smr, AT91_AIC5_SMR);
 	irq_gc_unlock(bgc);
 
 	return ret;