linux-kernel - Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160208110036.GC4117@kwain>
Date:	Mon, 8 Feb 2016 12:00:36 +0100
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	catalin.marinas@....com, will.deacon@....com,
	tsahee@...apurnalabs.com, linux-arm-kernel@...ts.infradead.org,
	rshitrit@...apurnalabs.com, thomas.petazzoni@...e-electrons.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Barak Wasserstrom <barak@...apurnalabs.com>
Subject: Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP

Hi Mark,

On Mon, Feb 08, 2016 at 10:51:05AM +0000, Mark Rutland wrote:
> 
> > +	chosen {
> > +		stdout-path = "console0:115200n8";
> > +	};
> 
> There is no console0 alias, so this cannot work.
> 
> Did you mean serial0?

Oops... Yes, I meant serial0. I'll fix this.

> [...]
> 
> > +	aliases {
> > +		serial0 = &uart0;
> > +		serial1 = &uart1;
> > +		serial2 = &uart2;
> > +		serial3 = &uart3;
> > +	};
> 
> [...]
> 
> > +	psci {
> > +		compatible = "arm,psci-0.2", "arm,psci";
> > +		method = "smc";
> > +		cpu_on = <0x84000003>;
> > +	};
> 
> If you have PSCI 0.2, the cpu_on ID (and all other mandatory function
> IDs) are implicit.
> 
> If you want to have "arm,psci" as a fallback, then please add the IDs
> for functions mandatory in PSCI 0.2 which existed in the "arm,psci"
> binding. Otherwise, drop "arm,psci" from the compatible list, along
> with the cpu_on function ID.

OK. I'll make some tests and update.

Thanks or the review!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)