linux-kernel - Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B87A58.6090304@sakamocchi.jp>
Date:	Mon, 8 Feb 2016 20:22:00 +0900
From:	Takashi Sakamoto <o-takashi@...amocchi.jp>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Takashi Iwai <tiwai@...e.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Damien Zammit <damien@...audio.com>,
	Robin Gareus <robin@...eus.org>
Subject: Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier
 on dot_scrt()

On Feb 7 2016 23:14, Geert Uytterhoeven wrote:
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
> 
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Yep. It came from original code[1] and I overlooked.

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

> ---
>  sound/firewire/digi00x/amdtp-dot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
>  #define BYTE_PER_SAMPLE (4)
>  #define MAGIC_DOT_BYTE (2)
>  #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
>  {
>  	/*
>  	 * the length of the added pattern only depends on the lower nibble

Thanks

[1] https://github.com/x42/003amdtp


Takashi Sakamoto