[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2409806.1aGBrN4l0X@wuerfel>
Date: Mon, 08 Feb 2016 14:50:15 +0100
From: Arnd Bergmann <arnd@...db.de>
To: linux-arm-kernel@...ts.infradead.org
Cc: Gabriele Paoloni <gabriele.paoloni@...wei.com>,
guohanjun@...wei.com, wangzhou1@...ilicon.com,
liudongdong3@...wei.com, linuxarm@...wei.com, qiujiang@...wei.com,
bhelgaas@...gle.com, Lorenzo.Pieralisi@....com, tn@...ihalf.com,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
xuwei5@...ilicon.com, linux-acpi@...r.kernel.org, jcm@...hat.com,
zhangjukuo@...wei.com, liguozhu@...ilicon.com
Subject: Re: [RFC PATCH v2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI
On Monday 08 February 2016 12:41:02 Gabriele Paoloni wrote:
> +
> +/* HipXX PCIe host only supports 32-bit config access */
> +int hisi_pcie_common_cfg_read(void __iomem *reg_base, int where, int size,
> + u32 *val)
> +{
> + u32 reg;
> + u32 reg_val;
> + void *walker = ®_val;
> +
> + walker += (where & 0x3);
> + reg = where & ~0x3;
> + reg_val = readl(reg_base + reg);
> +
> + if (size == 1)
> + *val = *(u8 __force *) walker;
> + else if (size == 2)
> + *val = *(u16 __force *) walker;
> + else if (size == 4)
> + *val = reg_val;
> + else
> + return PCIBIOS_BAD_REGISTER_NUMBER;
> +
> + return PCIBIOS_SUCCESSFUL;
> +}
Isn't this the same hack that Qualcomm are using?
Arnd
Powered by blists - more mailing lists