linux-kernel - Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B89E41.5090500@redhat.com>
Date:	Mon, 8 Feb 2016 14:55:13 +0100
From:	Tomas Henzl <thenzl@...hat.com>
To:	Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Cc:	Suganath prabu Subaramani 
	<suganath-prabu.subramani@...gotech.com>,
	"jejb@...nel.org" <jejb@...nel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Sathya Prakash <Sathya.Prakash@...gotech.com>,
	Kashyap Desai <kashyap.desai@...gotech.com>,
	Krishnaraddi Mankani <krishnaraddi.mankani@...gotech.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chaitra Basappa <chaitra.basappa@...gotech.com>,
	Sreekanth Reddy <sreekanth.reddy@...gotech.com>
Subject: Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable
 Chain Frame Size

On 5.2.2016 08:56, Sreekanth Reddy wrote:
> On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl <thenzl@...hat.com> wrote:
>> On 28.1.2016 07:37, Suganath prabu Subaramani wrote:
>>> From: Suganath prabu Subramani <suganath-prabu.subramani@...gotech.com>
>>>
>>> Added support for configurable Chain Frame Size. Calculate the
>>> Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts).
>>> Applicable only for mpt3sas/SAS3.0 HBA's.
>>>
>>> Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@...gotech.com>
>>> Signed-off-by: Chaitra P B <chaitra.basappa@...gotech.com>
>> Is this done in order to prepare for some future patch, or how  does it work?
>> I noticed only changes in allocation of (probably larger) fields, but
>> how is it actually used ?
> Tomas,
>
> In this patch set we have added new Intruder and Cutlass (high ports)
> PCI devices which are based on MPI26 version.
> In this MPI26 version, Request Frame size is doubled when compared to
> older MPI version, but their is
> no change in the Chain buffer size from MPI26 to older versions. In
> older version Request frame size and
> chain buffer size were same, so in the drivers previously we used to
> use Request Frame size reference for
> Chain buffer size. But we can't use that reference now. So now we are
> determining the chain buffer size from
> IOCFact's IOCMaxChainSegementSize field instead of using the Request
> frame size reference.
>
> ~Sreekanth

Thanks,

Reviewed-by: Tomas Henzl <thenzl@...hat.com>

Tomas