linux-kernel - Re: [PATCH] reset: socfpga: Make reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2016 22:43:49 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH] reset: socfpga: Make reset_control_ops const

Hi Philipp,

[auto build test WARNING on v4.5-rc3]
[also build test WARNING on next-20160208]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Philipp-Zabel/reset-socfpga-Make-reset_control_ops-const/20160208-213454
config: arm-multi_v7_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/reset/reset-socfpga.c: In function 'socfpga_reset_probe':
>> drivers/reset/reset-socfpga.c:134:18: warning: assignment discards 'const' qualifier from pointer target type
     data->rcdev.ops = &socfpga_reset_ops;
                     ^

vim +/const +134 drivers/reset/reset-socfpga.c

a39a4939 Steffen Trumtrar 2014-04-15  118  		return -ENOMEM;
a39a4939 Steffen Trumtrar 2014-04-15  119  
a39a4939 Steffen Trumtrar 2014-04-15  120  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
a39a4939 Steffen Trumtrar 2014-04-15  121  	data->membase = devm_ioremap_resource(&pdev->dev, res);
a39a4939 Steffen Trumtrar 2014-04-15  122  	if (IS_ERR(data->membase))
a39a4939 Steffen Trumtrar 2014-04-15  123  		return PTR_ERR(data->membase);
a39a4939 Steffen Trumtrar 2014-04-15  124  
27e44646 Dinh Nguyen      2015-07-31  125  	if (of_property_read_u32(np, "altr,modrst-offset", &data->modrst_offset)) {
27e44646 Dinh Nguyen      2015-07-31  126  		dev_warn(dev, "missing altr,modrst-offset property, assuming 0x10!\n");
27e44646 Dinh Nguyen      2015-07-31  127  		data->modrst_offset = 0x10;
27e44646 Dinh Nguyen      2015-07-31  128  	}
27e44646 Dinh Nguyen      2015-07-31  129  
a39a4939 Steffen Trumtrar 2014-04-15  130  	spin_lock_init(&data->lock);
a39a4939 Steffen Trumtrar 2014-04-15  131  
a39a4939 Steffen Trumtrar 2014-04-15  132  	data->rcdev.owner = THIS_MODULE;
a39a4939 Steffen Trumtrar 2014-04-15  133  	data->rcdev.nr_resets = NR_BANKS * BITS_PER_LONG;
a39a4939 Steffen Trumtrar 2014-04-15 @134  	data->rcdev.ops = &socfpga_reset_ops;
a39a4939 Steffen Trumtrar 2014-04-15  135  	data->rcdev.of_node = pdev->dev.of_node;
a39a4939 Steffen Trumtrar 2014-04-15  136  
d1f15aa0 Masahiro Yamada  2015-11-05  137  	return reset_controller_register(&data->rcdev);
a39a4939 Steffen Trumtrar 2014-04-15  138  }
a39a4939 Steffen Trumtrar 2014-04-15  139  
a39a4939 Steffen Trumtrar 2014-04-15  140  static int socfpga_reset_remove(struct platform_device *pdev)
a39a4939 Steffen Trumtrar 2014-04-15  141  {
a39a4939 Steffen Trumtrar 2014-04-15  142  	struct socfpga_reset_data *data = platform_get_drvdata(pdev);

:::::: The code at line 134 was first introduced by commit
:::::: a39a493932dfc534cb761d6f95861a281e57c1e7 reset: add driver for socfpga

:::::: TO: Steffen Trumtrar <s.trumtrar@...gutronix.de>
:::::: CC: Dinh Nguyen <dinguyen@...era.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (36557 bytes)