linux-kernel - Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160208155356.GV23093@windriver.com>
Date:	Mon, 8 Feb 2016 10:53:56 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<linux-kernel@...r.kernel.org>, Jingoo Han <jingoohan1@...il.com>,
	Pratyush Anand <pratyush.anand@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Stanimir Varbanov <svarbanov@...sol.com>,
	Thierry Reding <thierry.reding@...il.com>,
	<linux-pci@...r.kernel.org>
Subject: Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific
 PCI code to be tristate

[Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate] On 08/02/2016 (Mon 10:57) Arnd Bergmann wrote:

> On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote:
> > After converting the drivers who select PCI_DW from bool to tristate,
> > the following symbols need to be exported, simply based on the output
> > from modpost failures.
> > 
> > Cc: Jingoo Han <jingoohan1@...il.com>
> > Cc: Pratyush Anand <pratyush.anand@...il.com>
> > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> > Cc: Stanimir Varbanov <svarbanov@...sol.com>
> > Cc: Thierry Reding <thierry.reding@...il.com>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: linux-pci@...r.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> > 
> 
> Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These
> are just meant to be used internally by the drivers after all.

Sure, I can make that restriction.

P.
--

> 
> 	Arnd