linux-kernel - Re: [PATCH] staging: goldfish: Coding Style Fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 7 Feb 2016 18:29:44 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Benjamin Young <youngcdev@...il.com>
Cc:	sudipm.mukherjee@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred
 around that '+'

On Fri, Dec 11, 2015 at 04:38:59PM -0500, Benjamin Young wrote:
> Helped improve coding style to make arithemethic easier to read
> 
> Signed-off-by: Benjamin Young <youngcdev@...il.com>
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index b0927e4..f1e1838 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -63,7 +63,7 @@ struct goldfish_audio {
>  #define AUDIO_READ(data, addr)		(readl(data->reg_base + addr))
>  #define AUDIO_WRITE(data, addr, x)	(writel(x, data->reg_base + addr))
>  #define AUDIO_WRITE64(data, addr, addr2, x)	\
> -	(gf_write_dma_addr((x), data->reg_base + addr, data->reg_base+addr2))
> +	(gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
>  
>  /*
>   *  temporary variable used between goldfish_audio_probe() and

Someone else sent this before you did, sorry.

thanks,

greg k-h