linux-kernel - Re: [PATCH 1/1] ARM: kirkwood-ds112.dts: use unique machine name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h9hj19ek.fsf@free-electrons.com>
Date:	Mon, 08 Feb 2016 16:58:27 +0100
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Heinrich Schuchardt <xypron.glpk@....de>
Cc:	Andrew Lunn <andrew@...n.ch>, Jason Cooper <jason@...edaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Ben Peddell <klightspeed@...lerwolves.net>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ARM: kirkwood-ds112.dts: use unique machine name

Hi Heinrich,
 
 On dim., févr. 07 2016, Andrew Lunn <andrew@...n.ch> wrote:

> On Sun, Feb 07, 2016 at 07:34:26PM +0100, Heinrich Schuchardt wrote:
>> Downstream packages like Debian flash-kernel use
>> /proc/device-tree/model
>> to determine which dtb file to install.
>> 
>> Hence each dts in the Linux kernel should provide a unique model
>> identifier.
>> 
>> Commit 2d0a7addbd10 ("ARM: Kirkwood: Add support for many Synology NAS
>> devices") created the new files kirkwood-ds111.dts and kirkwood-ds112.dts
>> using the same model identifier.
>> 
>> This patch provides a unique model identifier for the
>> Synology DiskStation DS112.
>> 
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
>
> Fixes: 2d0a7addbd10 ("ARM: Kirkwood: Add support for many Synology NAS devices")
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied on mvebu/fixes with the Fixes tag and Andrew Reviewed-by tag.

Thanks,

Gregory



>
>     Thanks
> 	Andrew	     
>
>> ---
>>  arch/arm/boot/dts/kirkwood-ds112.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm/boot/dts/kirkwood-ds112.dts b/arch/arm/boot/dts/kirkwood-ds112.dts
>> index bf4143c..b84af3d 100644
>> --- a/arch/arm/boot/dts/kirkwood-ds112.dts
>> +++ b/arch/arm/boot/dts/kirkwood-ds112.dts
>> @@ -14,7 +14,7 @@
>>  #include "kirkwood-synology.dtsi"
>>  
>>  / {
>> -	model = "Synology DS111";
>> +	model = "Synology DS112";
>>  	compatible = "synology,ds111", "marvell,kirkwood";
>>  
>>  	memory {
>> -- 
>> 2.1.4
>> 

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com