linux-kernel - Re: [PATCH] reset: lpc18xx: Make reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2016 17:16:15 +0100
From:	Joachim Eastwood <manabian@...il.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] reset: lpc18xx: Make reset_control_ops const

Hi Philipp,

On 8 February 2016 at 14:28, Philipp Zabel <p.zabel@...gutronix.de> wrote:
> The lpc18xx_rgu_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/reset/reset-lpc18xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-lpc18xx.c b/drivers/reset/reset-lpc18xx.c
> index 70922e9..3b8a4f5 100644
> --- a/drivers/reset/reset-lpc18xx.c
> +++ b/drivers/reset/reset-lpc18xx.c
> @@ -136,7 +136,7 @@ static int lpc18xx_rgu_status(struct reset_controller_dev *rcdev,
>         return !(readl(rc->base + offset) & bit);
>  }
>
> -static struct reset_control_ops lpc18xx_rgu_ops = {
> +static const struct reset_control_ops lpc18xx_rgu_ops = {
>         .reset          = lpc18xx_rgu_reset,
>         .assert         = lpc18xx_rgu_assert,
>         .deassert       = lpc18xx_rgu_deassert,

Acked-by: Joachim Eastwood <manabian@...il.com>


regards,
Joachim Eastwood