linux-kernel - Re: [PATCH] ARM: mvebu: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8760xz17vr.fsf@free-electrons.com>
Date:	Mon, 08 Feb 2016 17:31:20 +0100
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-arm-kernel@...ts.infradead.org, Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Jason Cooper <jason@...edaemon.net>,
	linux-kernel@...r.kernel.org, Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] ARM: mvebu: add missing of_node_put()

Hi Masahiro,
 
 On lun., févr. 08 2016, Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> This node pointer is returned by of_find_compatible_node() in this
> function.  It should be put before exitting this function.
>

Applied on mvebu/cleanup

Thanks,

Gregory

> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  arch/arm/mach-mvebu/platsmp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c
> index f9597b7..46c742d 100644
> --- a/arch/arm/mach-mvebu/platsmp.c
> +++ b/arch/arm/mach-mvebu/platsmp.c
> @@ -140,6 +140,7 @@ static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus)
>  		panic("Cannot find 'marvell,bootrom' compatible node");
>  
>  	err = of_address_to_resource(node, 0, &res);
> +	of_node_put(node);
>  	if (err < 0)
>  		panic("Cannot get 'bootrom' node address");
>  
> -- 
> 1.9.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com