linux-kernel - Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160208165912.GK7265@sirena.org.uk>
Date:	Mon, 8 Feb 2016 16:59:12 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lee.jones@...aro.org, alexandre.belloni@...e-electrons.com,
	k.kozlowski@...sung.com, javier@....samsung.com,
	gregkh@...uxfoundation.org, a.zummo@...ertech.it,
	cw00.choi@...sung.com, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

On Mon, Feb 08, 2016 at 10:08:28PM +0530, Laxman Dewangan wrote:
> On Monday 08 February 2016 08:25 PM, Mark Brown wrote:
> >On Sat, Feb 06, 2016 at 08:07:22PM +0530, Laxman Dewangan wrote:

> >>Before removing irq domains, it is require to unmap all
> >>mapped interrupt from that domain. Currently there is API
> >>to map the interrupt on chip as regmap_irq_get_virq() for
> >>creating mapping. Add equivalent API to dispose the mapped
> >>irq in irq domains.

> >This makes no sense to me.  Why would you ever want to unmap the
> >interrupts separately to destroying the domain

> This is the requirement from irq_domain_remove(). This is what we have in
> irq_domain_remove():
> kernel/irq/irqdomain.c

> I am adding the API equivalent to regmap_irq_get_virq() to unmap virtual irq
> here.

This does not explain why anyone would ever want to use this interface
(which was my question), why would anyone ever want to do this as a
separate step?

> >and why would you ever
> >want to destroy the domain without unmapping the interrupts?

> That's exactlly we are trying to do, unmap interrupt in client level before
> destroying domain.

Again, why would any client ever want to skip this step? 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)