linux-kernel - Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160208172831.GB6715@kroah.com>
Date:	Mon, 8 Feb 2016 09:28:31 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Vladimir Murzin <vladimir.murzin@....com>
Cc:	arnd@...db.de, linux@....linux.org.uk, daniel.lezcano@...aro.org,
	tglx@...utronix.de, u.kleine-koenig@...gutronix.de,
	andy.shevchenko@...il.com, mark.rutland@....com,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, jslaby@...e.cz, robh+dt@...nel.org,
	devicetree@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-api@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote:
> On 08/02/16 16:52, Greg KH wrote:
> > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote:
> >> On 07/02/16 07:11, Greg KH wrote:
> >>>> +
> >>>> +#define SERIAL_NAME "ttyS"
> >>>
> >>> You can't be "ttyS", there's already a serial port named that, please
> >>> use a unique name and a new major/minor number (dynamic ideally).
> >>>
> >>
> >> Hi Greg,
> >>
> >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
> >> back if you prefer that, but I'd be glad to know what I've been missing?
> >>
> >> [1] https://lkml.org/lkml/2015/12/13/8
> > 
> > Yeah, I was wrong, sorry about that, my fault.
> > 
> 
> I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"?

Please use ttyMPS.

> P.S.
> Any chance you could look at the rest of the patch?

It's long gone from my queue, sorry, you'll have to resend it.

thanks,

greg k-h