linux-kernel - Re: [PATCH] iio: Fix documentation for iio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56B8DFCA.9010807@kernel.org>
Date:	Mon, 8 Feb 2016 18:34:50 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: Fix documentation for iio_dev mlock

On 08/02/16 15:03, Daniel Baluta wrote:
> mlock *must* be used by core and drivers to protect access
> to devices state changes.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
Applied. Thanks for cleaning this up.

Jonathan
> ---
> At a first glance there are few places where access to iio_dev
> state changes are done without mlock protection. Will fix them
> with follow up patches.
> 
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index b589411..ce9e9c1 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
>   * @buffer:		[DRIVER] any buffer present
>   * @buffer_list:	[INTERN] list of all buffers currently attached
>   * @scan_bytes:		[INTERN] num bytes captured to be fed to buffer demux
> - * @mlock:		[INTERN] lock used to prevent simultaneous device state
> + * @mlock:		[DRIVER] lock used to prevent simultaneous device state
>   *			changes
>   * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
>   * @masklength:		[INTERN] the length of the mask established from
>