lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CALAqxLUq36L_L+-yEvFVYxamvk_=tF3b7ROXWr=qD_oGdGykOQ@mail.gmail.com>
Date:	Mon, 8 Feb 2016 10:50:57 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	lkml <linux-kernel@...r.kernel.org>, San Mehat <san@...gle.com>,
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak

On Sun, Feb 7, 2016 at 2:49 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote:
>> From: San Mehat <san@...gle.com>
>>
>> As it turns out, the CONFIG_PROFILING interfaces leak a
>> task struct if the notifier chain returns NOTIFY_OK.. doh.
>>
>> This patch reworks lowmemkiller to use the new generic task
>> free notifier chain.
>>
>> Cc: Android Kernel Team <kernel-team@...roid.com>
>> Cc: Greg KH <gregkh@...uxfoundation.org>
>> Signed-off-by: San Mehat <san@...gle.com>
>> [jstultz: Commit subject tweak]
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>  drivers/staging/android/lowmemorykiller.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
>> index 8b5a4a8..806643d 100644
>> --- a/drivers/staging/android/lowmemorykiller.c
>> +++ b/drivers/staging/android/lowmemorykiller.c
>> @@ -40,7 +40,6 @@
>>  #include <linux/sched.h>
>>  #include <linux/swap.h>
>>  #include <linux/rcupdate.h>
>> -#include <linux/profile.h>
>>  #include <linux/notifier.h>
>>
>>  static u32 lowmem_debug_level = 1;
>> --
>> 1.9.1
>
> The changelog comment seems a bit "odd" when looking at the patch here.
> Is the patch really correct?  The changelog?

Yea. Sorry for my oversight here. Had to do some patch archaeology and
found that the content of that patch basically dropped out when
83dbbdbb38 ("android, lowmemorykiller: remove task handoff notifier")
landed upstream in 3.4. Since then its been rebased along being
basically content-less.

So please ignore it.  I'll try to get it dropped from the AOSP tree.

thanks
-john

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ