linux-kernel - Re: [PATCH] locking/static_keys: avoid nested functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B8E7D9.1080301@akamai.com>
Date:	Mon, 8 Feb 2016 14:09:13 -0500
From:	Jason Baron <jbaron@...mai.com>
To:	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/static_keys: avoid nested functions

On 02/08/2016 09:36 AM, Arnd Bergmann wrote:
> clang does not support nested functions inside of an array definition:
> 
> lib/test_static_keys.c:105:16: error: function definition is not allowed here
>                         .test_key       = test_key_func(&old_true_key, static_key_true),
> lib/test_static_keys.c:50:20: note: expanded from macro 'test_key_func'
>         ({bool func(void) { return branch(key); } func; })
> 
> That code appears to have been a little too clever, so this
> simplifies it a bit by defining functions outside of the array.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  lib/test_static_keys.c | 62 ++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 42 insertions(+), 20 deletions(-)
> 

Works for me.

Acked-by: Jason Baron <jbaron@...mai.com>

Thanks,

-Jason