linux-kernel - Re: [PATCH v2 2/2] rng: pic32-rng: Add PIC32 RNG hardware driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160208213407.GA9389@wychelm.lan>
Date:	Mon, 8 Feb 2016 21:34:07 +0000
From:	Daniel Thompson <daniel.thompson@...aro.org>
To:	Joshua Henderson <joshua.henderson@...rochip.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Purna Chandra Mandal <purna.mandal@...rochip.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Kieran Bingham <kieranbingham@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Pankaj Dev <pankaj.dev@...com>,
	Scott Branden <sbranden@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2 2/2] rng: pic32-rng: Add PIC32 RNG hardware driver

On Mon, Feb 08, 2016 at 02:17:53PM -0700, Joshua Henderson wrote:
> Add support for the hardware true random number generator
> peripheral found on PIC32.
> 
> Signed-off-by: Joshua Henderson <joshua.henderson@...rochip.com>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@...rochip.com>

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
> Changes since v1:
> 	- Reorder includes to be alphabetic.
> 	- Drop use of PRNG and only use TRNG.

Excellent!



> 	- Fix dangling clock ref in error condition.
> 	- Remove unecessary error handling and fix other cases.


Daniel.