linux-kernel - Re: [PATCH] mtd: denali: fix property name for Denali DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2016 15:37:57 -0600
From:	Rob Herring <robh@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-mtd@...ts.infradead.org,
	Dinh Nguyen <dinguyen@...era.com>, devicetree@...r.kernel.org,
	Kumar Gala <galak@...eaurora.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] mtd: denali: fix property name for Denali DT binding

On Mon, Feb 08, 2016 at 05:41:33PM +0900, Masahiro Yamada wrote:
> Hi Arnd,
> 
> 
> 2016-02-08 17:29 GMT+09:00 Arnd Bergmann <arnd@...db.de>:
> > On Monday 08 February 2016 16:31:42 Masahiro Yamada wrote:
> >> diff --git a/Documentation/devicetree/bindings/mtd/denali-nand.txt b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> index b04d03a..785b825 100644
> >> --- a/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> +++ b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> @@ -5,7 +5,7 @@ Required properties:
> >>    - reg : should contain registers location and length for data and reg.
> >>    - reg-names: Should contain the reg names "nand_data" and "denali_reg"
> >>    - interrupts : The interrupt number.
> >> -  - dm-mask : DMA bit mask
> >> +  - dma-mask : DMA bit mask
> >>
> >>  The device tree may optionally contain sub-nodes describing partitions of the
> >>  address space. See partition.txt for more detail.
> >>
> >
> > It looks like this binding is wrong in multiple ways, and it doesn't seem to
> > be used in any .dts files. Is this actually being shipped anywhere or
> > could we try to fix the binding properly?
> >
> 
> Looks like it is locally used in Altera's Rocketboard tree now.
> 
> See this:
> 
> https://github.com/altera-opensource/linux-socfpga/blob/socfpga-4.3/arch/arm/boot/dts/socfpga.dtsi
> 
> 
> I hope Dinh can comment on the status.

>From the looks of it, this property should be dropped and the driver 
should be updated to not touch dev->dma_mask. The core sets it up 
correctly now.

Rob