linux-kernel - Re: [PATCH] staging: dgnc: convert to wait_event_interruptible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160208040953.GA30989@kroah.com>
Date:	Sun, 7 Feb 2016 20:09:53 -0800
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"Gujulan Elango, Hari Prasath (H.)" <hgujulan@...teon.com>
Cc:	"lidza.louina@...il.com" <lidza.louina@...il.com>,
	"markh@...pro.net" <markh@...pro.net>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: dgnc: convert to
 wait_event_interruptible_timeout

On Thu, Dec 24, 2015 at 01:54:12PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> This patch makes use of wait_event_interruptible_timeout to achieve timeout
> functionality.This is a TODO mentiond in the comment which is also removed.
> It also aligns with what the function is supposed to do as in the
> comments.
> 
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@...teon.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 39c76e7..7d9efe0 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1306,10 +1306,8 @@ static int neo_drain(struct tty_struct *tty, uint seconds)
>  	/*
>  	 * Go to sleep waiting for the tty layer to wake me back up when
>  	 * the empty flag goes away.
> -	 *
> -	 * NOTE: TODO: Do something with time passed in.
>  	 */
> -	rc = wait_event_interruptible(un->un_flags_wait, ((un->un_flags & UN_EMPTY) == 0));
> +	rc = wait_event_interruptible_timeout(un->un_flags_wait, ((un->un_flags & UN_EMPTY) == 0), msecs_to_jiffies(seconds * 1000));

Any reason you didn't properly wrap your line at the 80 column limit?

Please fix and resend.

thanks,

greg k-h