linux-kernel - Re: [PATCH] x86/kernel: use pr_<level>() and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Feb 2016 15:53:08 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...nel.org>, Chen Yucong <slaoub@...il.com>
Cc:	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>

On Tue, 2016-02-09 at 10:57 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@...il.com> wrote:
> 
> > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_().
> > This patch converts the bulk of printk(KERN_ ) to pr_() and
> > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> > calls have been replaced with pr_warn().
> > 
> > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> > log level.
> > 
> > Signed-off-by: Chen Yucong <slaoub@...il.com>
> 
> When converting please also join broken up format strings, such as:
> 
> -               printk(KERN_WARNING PREFIX
> -                      "HPET id: %#x base: 0xfed0000000000000 fixed up "
> -                      "to 0xfed00000.\n", hpet_tbl->id);
> +               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
> +                       "to 0xfed00000.\n", hpet_tbl->id);
> 
> ignore checkpatch: we don't line-break user visible strings.

Umm, checkpatch already suggests to coalesce split strings.

ie:

WARNING: quoted string split across lines
#850: FILE: arch/x86/kernel/hpet.c:850:
+			       "HPET config register value = 0xFFFFFFFF. "
+			       "Disabling HPET\n");

and checkpatch does the fixing using something like:

$ ./scripts/checkpatch.pl -f --fix-inplace --types=split_string arch/x86/kernel/hpet.c