linux-kernel - Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454986452.17393.1.camel@ellerman.id.au>
Date:	Tue, 09 Feb 2016 13:54:12 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Luis Henriques <luis.henriques@...onical.com>,
	Geoff Levand <geoff@...radead.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>
Cc:	Joe Perches <joe@...ches.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of
 network data structs

On Mon, 2016-02-08 at 22:27 +0000, Luis Henriques wrote:

> Several network-related data structures are defined in gelic_udbg.
> These could be easily dropped and the standard ones defined in network
> headers could be used instead.
> 
> The 4 patches that follow replace ethernet, vlan, ip and udp
> structures in gelic_udbg.  Note that this has been compile-tested
> only.
> 
> Changes since v1:
> Include changes suggested by Joe Perches, namely the usage of
> eth_broadcast_addr(), ETH_ALEN, ETH_P_8021Q and ETH_P_IP.
> 
> Luis Henriques (4):
>   powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
>   powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h>
>   powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h>
>   powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h>


These look good. But I don't have a setup to test them, does anyone?

I'll merge them and hopefully someone can test them at some point.

cheers