linux-kernel - Re: [PATCH v4 16/17] FDT: Add a helper to get specified name subnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK8F6PQX2kC_+CtDk1-ykKRB3YB54o4FaypsRY_tNzK5w@mail.gmail.com>
Date:	Mon, 8 Feb 2016 23:04:56 -0600
From:	Rob Herring <robh@...nel.org>
To:	Shannon Zhao <zhaoshenglong@...wei.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Stefano Stabellini <stefano.stabellini@...rix.com>,
	david.vrabel@...rix.com, Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Mark Rutland <mark.rutland@....com>, julien.grall@...rix.com,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	shannon.zhao@...aro.org, peter.huangpeng@...wei.com
Subject: Re: [PATCH v4 16/17] FDT: Add a helper to get specified name subnode

On Thu, Feb 4, 2016 at 9:05 PM, Shannon Zhao <zhaoshenglong@...wei.com> wrote:
> From: Shannon Zhao <shannon.zhao@...aro.org>
>
> Sometimes it needs to check if there is a node in FDT by full path.

I'm confused. Are you searching by full path or...

> Introduce this helper to get the specified name subnode if it exists.

name of sub node?

Either way, fdt_subnode_offset or fdt_path_offset doesn't work?

>
> Signed-off-by: Shannon Zhao <shannon.zhao@...aro.org>
> ---
> CC: Rob Herring <robh@...nel.org>
> ---
>  drivers/of/fdt.c       | 25 +++++++++++++++++++++++++
>  include/linux/of_fdt.h |  2 ++
>  2 files changed, 27 insertions(+)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 655f79d..eacb188 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -645,6 +645,31 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node,
>  }
>
>  /**
> + * of_get_flat_dt_subnode_by_name - get subnode of specified node by name
> + *
> + * @node: the parent node
> + * @uname: the name of subnode
> + * @return offset of the subnode, or -FDT_ERR_NOTFOUND if there is none
> + */
> +
> +int of_get_flat_dt_subnode_by_name(unsigned long node, const char *uname)
> +{
> +       const void *blob = initial_boot_params;
> +       int offset;
> +       const char *pathp;
> +
> +       for (offset = fdt_first_subnode(blob, node);
> +            offset >= 0;
> +            offset = fdt_next_subnode(blob, offset)) {
> +               pathp = fdt_get_name(blob, offset, NULL);
> +               if (strcmp(pathp, uname) == 0)
> +                       return offset;
> +       }
> +
> +       return -FDT_ERR_NOTFOUND;
> +}
> +
> +/**
>   * of_get_flat_dt_root - find the root node in the flat blob
>   */
>  unsigned long __init of_get_flat_dt_root(void)
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index df9ef38..fc28162 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -52,6 +52,8 @@ extern char __dtb_end[];
>  extern int of_scan_flat_dt(int (*it)(unsigned long node, const char *uname,
>                                      int depth, void *data),
>                            void *data);
> +extern int of_get_flat_dt_subnode_by_name(unsigned long node,
> +                                         const char *uname);
>  extern const void *of_get_flat_dt_prop(unsigned long node, const char *name,
>                                        int *size);
>  extern int of_flat_dt_is_compatible(unsigned long node, const char *name);
> --
> 2.0.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html