linux-kernel - Re: [PATCH] ch7006: correctly handling failed allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 10:22:20 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Insu Yun <wuninsu@...il.com>
Cc:	airlied@...ux.ie, daniel.vetter@...ll.ch,
	ville.syrjala@...ux.intel.com, alexander.deucher@....com,
	treding@...dia.com, boris.brezillon@...e-electrons.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu,
	changwoo@...ech.edu
Subject: Re: [PATCH] ch7006: correctly handling failed allocation

On Thu, Jan 28, 2016 at 06:54:36PM -0500, Insu Yun wrote:
> Since drm_property_create_range can be failed in memory pressure,
> it needs to be checked and return -ENOMEM.
> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
> index 90db5f4..0594c45 100644
> --- a/drivers/gpu/drm/i2c/ch7006_drv.c
> +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
> @@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder,
>  	drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names);
>  
>  	priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2);
> +	if (!priv->scale_property)
> +		return -ENOMEM;
>  
>  	drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property,
>  				      priv->select_subconnector);
> -- 
> 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch