linux-kernel - Re: [PATCH] x86/kernel: use pr_<level>() and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 10:57:49 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Chen Yucong <slaoub@...il.com>
Cc:	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>


* Chen Yucong <slaoub@...il.com> wrote:

> arch/x86/kernel/* use a mixture of printk(KERN_<level> ) and pr_<level>().
> This patch converts the bulk of printk(KERN_<level> ) to pr_<level>() and
> uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> calls have been replaced with pr_warn().
> 
> Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> log level.
> 
> Signed-off-by: Chen Yucong <slaoub@...il.com>

When converting please also join broken up format strings, such as:

-               printk(KERN_WARNING PREFIX
-                      "HPET id: %#x base: 0xfed0000000000000 fixed up "
-                      "to 0xfed00000.\n", hpet_tbl->id);
+               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
+                       "to 0xfed00000.\n", hpet_tbl->id);

ignore checkpatch: we don't line-break user visible strings.

Thanks,

	Ingo