linux-kernel - Re: [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4mdixg4n.wl-tiwai@suse.de>
Date:	Tue, 09 Feb 2016 12:44:24 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Martin Kepplinger" <martink@...teo.de>
Cc:	<david.henningsson@...onical.com>, <han.lu@...el.com>,
	<libin.yang@...el.com>, <treding@...dia.com>, <perex@...ex.cz>,
	<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915

On Tue, 09 Feb 2016 07:34:48 +0100,
Martin Kepplinger wrote:
> 
> The following change:
> 
> 788d441 ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling
> 
> breaks audio over HDMI on my snd_hda_intel laptop. It is the first bad
> commit.
> 
> This was merged for -rc1 and isn't fixed until now, so I got nervous.
> There are
> no errors in the log that stand out. I'm no sound or alsa developer, and
> just reverting it isn't easy since there is stuff depending on this.
> 
> I'm happy to test possible fixes and hope v4.5 not to ship with such a big
> regression ;)

Could you give a bit more detail about your hardware?  At best, give
alsa-info.sh output (run with --no-upload option).  Also, give the
output of dmesg, too.

In addition, what shows /proc/asound/card*/eld#*.* files?  Does any of
it show the proper connection state and ELD?

A simple revert of the commit is a patch like below.  Does it make the
HDMI audio working again?


thanks,

Takashi

---
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -156,7 +156,7 @@ struct hdmi_spec {
 	bool i915_bound; /* was i915 bound in this driver? */
 };
 
-#ifdef CONFIG_SND_HDA_I915
+#if 0
 #define codec_has_acomp(codec) \
 	((codec)->bus->core.audio_component != NULL)
 #else