linux-kernel - Re: [PATCH] tty: add Moxa Smartio MUE serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 13:10:00 +0100
From:	Mathieu OTHACEHE <m.othacehe@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	Joe Perches <joe@...ches.com>, gnomes@...rguk.ukuu.org.uk,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: add Moxa Smartio MUE serial driver

> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
> infrastructure?

Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie.
The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c).
I'm trying to do the same thing with the mxupcie driver.

mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not
have independant drivers ?

Mathieu