linux-kernel - Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B9E93A.2040903@osg.samsung.com>
Date:	Tue, 9 Feb 2016 10:27:22 -0300
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Laxman Dewangan <ldewangan@...dia.com>, lee.jones@...aro.org,
	alexandre.belloni@...e-electrons.com, k.kozlowski@...sung.com,
	broonie@...nel.org, gregkh@...uxfoundation.org,
	a.zummo@...ertech.it
Cc:	cw00.choi@...sung.com, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before
 removing domain

Hello Laxman,

On 02/09/2016 09:28 AM, Laxman Dewangan wrote:
> It is require to dispose all virtual irq of hwirq on chip
> created on given irq domain before removing this irq domain.
> Hence dispose all mapped irqs before deleting the irq domains
> in regmap_del_irq_chip();
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>

I believe this patch could be picked separately and not made part of
this series since is fixing a bug that happens on most drivers using
the regmap-irq API. This will avoid cross-subsystem churn for people.

Your patch 6/6 does not introduce a regression since the bug already
exists in the MFD driver, it just makes it more noticeable since it
is easier to unbind the max77686 RTC driver than the MFD one.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America