[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160209114228.70539d24@recife.lan>
Date: Tue, 9 Feb 2016 11:42:28 -0200
From: Mauro Carvalho Chehab <mchehab@....samsung.com>
To: Shuah Khan <shuahkh@....samsung.com>
Cc: tiwai@...e.com, clemens@...isch.de, hans.verkuil@...co.com,
laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
javier@....samsung.com, pawel@...iak.com, m.szyprowski@...sung.com,
kyungmin.park@...sung.com, perex@...ex.cz, arnd@...db.de,
dan.carpenter@...cle.com, tvboxspy@...il.com, crope@....fi,
ruchandani.tina@...il.com, corbet@....net, chehabrafael@...il.com,
k.kozlowski@...sung.com, stefanr@...6.in-berlin.de,
inki.dae@...sung.com, jh1009.sung@...sung.com,
elfring@...rs.sourceforge.net, prabhakar.csengg@...il.com,
sw0312.kim@...sung.com, p.zabel@...gutronix.de,
ricardo.ribalda@...il.com, labbott@...oraproject.org,
pierre-louis.bossart@...ux.intel.com, ricard.wanderlof@...s.com,
julian@...st.de, takamichiho@...il.com, dominic.sacre@....de,
misterpib@...il.com, daniel@...que.org, gtmkramer@...all.nl,
normalperson@...t.net, joe@...po.co.uk, linuxbugs@...tgam.net,
johan@...ud.se, klock.android@...il.com, nenggun.kim@...sung.com,
j.anaszewski@...sung.com, geliangtang@....com,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
alsa-devel@...a-project.org
Subject: Re: [PATCH v2 20/22] media: au0828 add enable, disable source
handlers
Em Mon, 08 Feb 2016 16:00:26 -0700
Shuah Khan <shuahkh@....samsung.com> escreveu:
> >>> + ret = __media_entity_pipeline_start(entity, pipe);
> >>> + if (ret) {
> >>> + pr_err("Start Pipeline: %s->%s Error %d\n",
> >>> + source->name, entity->name, ret);
> >>> + ret = __media_entity_setup_link(found_link, 0);
> >>> + pr_err("Deactive link Error %d\n", ret);
> >>> + goto end;
> >>> + }
> >>
> >> Hmm... isn't it to early to activate the pipeline here? My original
> >> guess is that, on the analog side, this should happen only at the stream
> >> on code. Wouldn't this break apps like mythTV?
>
> On analog side, there are a few ioctls that
> change the configuration on the tuner way
> before stream on step. Is there a reason to
> separate the setup_link() and pipeline_start()
> steps? I can separate these two steps, but I
> am not really seeing the reason for that.
I'm actually ok with that, provided that it won't break existing
apps. Did you test it with MythTV?
Regards,
Mauro
Powered by blists - more mailing lists